Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch3 #1051

Closed
wants to merge 4 commits into from
Closed

Patch3 #1051

wants to merge 4 commits into from

Conversation

vijaynaidu16
Copy link

πŸ› οΈ Fixes Issue (Number)

  • Responsive
  • Toggle Bar

Closes #issue_number

πŸ‘¨β€πŸ’» Changes proposed

I made a Tesla UI clone form its website using HTML,CSS,JavaScript and make it responsive

βœ… Check List (Check all the applicable boxes)

  • You have linked this PR to the correct issue.
  • My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

image

@Anmol-Baranwal Anmol-Baranwal self-requested a review May 21, 2023 20:10
Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijaynaidu16

It is recommended to read the contributing guidelines.

Follow the correct directory structure of the repository. All files like css, js, video, images.. are in assets directory and html files are in Public directory

Could you please update the file paths in the code to reflect the recent changes? It's important to ensure that the paths are correctly pointing to the updated files. If you need any assistance with this, feel free to let me know.


Additionally, it would be great if you could apply a white background color to the navigation section. This is an optional suggestion, but I highly recommend implementing it as it can improve the overall aesthetics and readability of the navigation area.

Please don't hesitate to reach out if you have any further questions or need any further assistance. I'm here to help!

Let me know if there are any specific points you'd like to discuss or clarify.

</svg>
</a>
<nav class="center desktop">
<a href="im">Model S</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="im">Model S</a>
<a href="">Model S</a>

To ensure a consistent user experience, it is important to avoid confusing users when they click on a link and encounter an error. Therefore, it would be beneficial to make the linking consistent.

Additionally, it would greatly enhance user convenience if you could implement internal linking within the sections of the website from the navbar. This functionality should be available on both mobile and desktop versions.

@Astrodevil Astrodevil closed this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you @vijaynaidu16 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants