-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ TopAppBarMenu - add custom menu #193
Merged
AdrienCasta
merged 2 commits into
main
from
task/rew-287-modifier-la-topappbar-pour-integrer-un-sous-menu
Feb 29, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| import React from 'react'; | ||
| import { TopAppBar } from '../../components/topAppBar/TopAppBar'; | ||
| import { | ||
| cleanUpFakeTimer, | ||
| render, | ||
| screen, | ||
| setupFakeTimer, | ||
| userEvent, | ||
| waitForElementToBeRemoved, | ||
| } from '../../shared/testUtils'; | ||
| import { Text } from 'react-native'; | ||
| import { IconName } from '../../components/icons/IconProps'; | ||
| import TopAppBarMenuItem from '../../components/topAppBar/Menu/TopAppBarMenuItem'; | ||
|
|
||
| const topBarTitle = 'Menu'; | ||
|
|
||
| describe('TopAppBar mounting with a simple title', () => { | ||
| it('displays a title', () => { | ||
| const title = { | ||
| value: topBarTitle, | ||
| }; | ||
|
|
||
| render(<TopAppBar title={title} />); | ||
|
|
||
| expect(screen.getByText(topBarTitle)).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it.todo("testing menu title 'as string' on press"); | ||
| }); | ||
|
|
||
| describe('TopAppBar mounting with a title by passing a custom component', () => { | ||
| it('displays a title', () => { | ||
| const title = { | ||
| value: <Text>{topBarTitle}</Text>, | ||
| }; | ||
|
|
||
| render(<TopAppBar title={title} />); | ||
|
|
||
| expect(screen.getByText(topBarTitle)).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it.todo("testing menu title 'as component' on press"); | ||
| }); | ||
|
|
||
| describe('TopAppBar mounting with a go back button', () => { | ||
| beforeEach(() => setupFakeTimer()); | ||
| afterEach(() => cleanUpFakeTimer()); | ||
| it('triggers `goBack` event when user press the go back button', async () => { | ||
| const user = userEvent.setup(); | ||
|
|
||
| const mockOnGoBack = jest.fn(); | ||
|
|
||
| const title = { | ||
| value: topBarTitle, | ||
| }; | ||
|
|
||
| render(<TopAppBar title={title} onBack={mockOnGoBack} />); | ||
|
|
||
| expect(mockOnGoBack).not.toHaveBeenCalled(); | ||
|
|
||
| await user.press(screen.getByLabelText(/back/i)); | ||
|
|
||
| expect(mockOnGoBack).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); | ||
|
|
||
| describe('TopAppBar mounting with a menu', () => { | ||
| const menuIconName = 'notifications-off' as const satisfies IconName; | ||
| const menuTitle = 'Ne plus surveiller'; | ||
| const title = { | ||
| value: topBarTitle, | ||
| }; | ||
| let mockOnMenuItemPress: jest.Mock; | ||
|
|
||
| beforeEach(() => { | ||
| setupFakeTimer(); | ||
| mockOnMenuItemPress = jest.fn(); | ||
|
|
||
| render( | ||
| <TopAppBar | ||
| title={title} | ||
| action={ | ||
| <TopAppBar.Menu> | ||
| <TopAppBarMenuItem | ||
| iconName={menuIconName} | ||
| title={menuTitle} | ||
| onPress={mockOnMenuItemPress} | ||
| /> | ||
| </TopAppBar.Menu> | ||
| } | ||
| />, | ||
| ); | ||
| }); | ||
| afterEach(() => cleanUpFakeTimer()); | ||
|
|
||
| it('displays action menu button', () => { | ||
| expect(screen.getByLabelText(/menu/i)).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it('displays menu items when user press the action menu button', async () => { | ||
| const user = userEvent.setup(); | ||
|
|
||
| expect(screen.queryByText(menuTitle)).not.toBeOnTheScreen(); | ||
|
|
||
| await user.press(screen.getByLabelText(/menu/i)); | ||
|
|
||
| expect(screen.getByText(menuTitle)).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it('retrieves menu item data when user press a menu item', async () => { | ||
| const user = userEvent.setup(); | ||
|
|
||
| await user.press(screen.getByLabelText(/menu/i)); | ||
|
|
||
| expect(mockOnMenuItemPress).not.toHaveBeenCalled(); | ||
|
|
||
| await user.press(screen.getByText(menuTitle)); | ||
|
|
||
| expect(mockOnMenuItemPress).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('hides menu when user press a menu item', async () => { | ||
| const user = userEvent.setup(); | ||
|
|
||
| await user.press(screen.getByLabelText(/menu/i)); | ||
|
|
||
| expect(screen.getByText(menuTitle)).toBeOnTheScreen(); | ||
|
|
||
| await user.press(screen.getByText(menuTitle)); | ||
|
|
||
| await waitForElementToBeRemoved(() => screen.queryByText(menuTitle)); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A implémenter ou supprimer 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Créer un ticket et lier le todo au ticket.