PR login name for google-readability-todo
#102
Comments
|
Should be possible to pass that in as an argument? |
|
Should be able to do this with the github api and setting the docker's env without needing an argument. I don't see why we'd want an argument for this unless users prefer using something else than |
bwrsandman
added a commit
to bwrsandman/clang-tidy-review
that referenced
this issue
Jan 16, 2024
Improves the recommendation for `google-readability-todo` by providing a proper name which would previously be `TODO(docker)` or `TODO(unknown)`. If for whatever reason, the name cannot be found, it will default to `TODO(your name here)`. Implements ZedThree#102 without the need for a new parameter.
bwrsandman
added a commit
to bwrsandman/clang-tidy-review
that referenced
this issue
Jan 16, 2024
Improves the recommendation for `google-readability-todo` by providing a proper name which would previously be `TODO(docker)` or `TODO(unknown)`. If for whatever reason, the name cannot be found, it will default to `TODO(your name here)`. Implements ZedThree#102 without the need for a new parameter.
bwrsandman
added a commit
to bwrsandman/clang-tidy-review
that referenced
this issue
Jan 16, 2024
Improves the recommendation for `google-readability-todo` by providing a proper name which would previously be `TODO(docker)` or `TODO(unknown)`. If for whatever reason, the name cannot be found, it will default to `TODO(your name here)`. Implements ZedThree#102 without the need for a new parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be useful if the PR author's username was used for the suggested fix of
google-readability-todo.Currently it has
unknown.Clang-tidy gets the name from the
USERenvironment variable, the config parameter and the config files.This is how I would do it if it wasn't in a container.
USER: ${{ github.event.pull_request.user.login }}The text was updated successfully, but these errors were encountered: