Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Address a port conflict issue in the non-blocking logger test #8658

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jun 28, 2024

Motivation

The non_blocking_logger() test was missed when disabling tests that could cause port conflicts in #8551 and when addressing port conflict issues in #8624 to close #8553.

We want to avoid port conflicts in this test too.

Solution

Uses an OS-assigned port in the non_blocking_logger() test's Zebrad child process's RPC listen address, and read the listen address from Zebra's logs

Follow-up Work

Try addressing port conflicts in tests related to Zebra's tracing filter and prometheus metrics endpoints as well. Search for uses of random_known_port() and limit its usage to the local_listener_fixed_port_localhost_addr_v4() and local_listener_fixed_port_localhost_addr_v6() tests.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

…child config and read the RPC port from Zebra's logs
@arya2 arya2 added C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jun 28, 2024
@arya2 arya2 self-assigned this Jun 28, 2024
@arya2 arya2 requested a review from a team as a code owner June 28, 2024 18:19
@arya2 arya2 requested review from oxarbitrage and removed request for a team June 28, 2024 18:19
@arya2 arya2 mentioned this pull request Jun 28, 2024
43 tasks
@mpguerra mpguerra removed the request for review from oxarbitrage July 8, 2024 10:26
@mpguerra
Copy link
Contributor

mpguerra commented Jul 8, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jul 8, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 09935bb into main Jul 8, 2024
132 checks passed
@mergify mergify bot deleted the fix-port-conflict-in-non-blocking-logger-test branch July 8, 2024 10:47
@arya2 arya2 mentioned this pull request Aug 1, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re enable port conflict related Windows tests
3 participants