fix(tests): Address a port conflict issue in the non-blocking logger test #8658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
non_blocking_logger()
test was missed when disabling tests that could cause port conflicts in #8551 and when addressing port conflict issues in #8624 to close #8553.We want to avoid port conflicts in this test too.
Solution
Uses an OS-assigned port in the
non_blocking_logger()
test's Zebrad child process's RPC listen address, and read the listen address from Zebra's logsFollow-up Work
Try addressing port conflicts in tests related to Zebra's tracing filter and prometheus metrics endpoints as well. Search for uses of
random_known_port()
and limit its usage to thelocal_listener_fixed_port_localhost_addr_v4()
andlocal_listener_fixed_port_localhost_addr_v6()
tests.PR Author's Checklist
PR Reviewer's Checklist