feature: Use zstd compression with sled #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using compression could save a lot of disk space, without much impact on CPU usage, as long as we set a low compression level. Overrides the secp256k1 version with a commit on their master branch, to resolve a "cc" crate version conflict with zstd (used by sled). Closes ZcashFoundation#776.
teor2345
added
A-dependencies
5 tasks
|
In my initial testing, sled+zstd uses 4 GB more for testnet. I'm putting this in draft until I've checked those results. |
|
Per #776 (comment) I think that it would be fine to wait on this until after we settle on a data format. |
|
Closing this for now, we can re-open when we have a stable on-disk format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using compression could save a lot of disk space, without much impact on
CPU usage, as long as we set a low compression level.
Overrides the secp256k1 version with a later commit on their master branch,
to resolve a "cc" crate version conflict with zstd (used by sled).
Closes #776.
I'm not sure if we want to do an override, or just wait for the next secp256k1
release.