cleanup(rust): Simplify code using closure capture in Rust 2021 edition #6737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rust's new closure capture rules in the 2021 edition allow us to simplify some code.
There are some new clippy errors in Rust nightly.
Reference
In Rust 2021 edition, closures only capture the fields they need to, not the entire
self
or argument:https://doc.rust-lang.org/edition-guide/rust-2021/disjoint-capture-in-closures.html
Solution
Remove a temporary variable
Fix clippy lints
Review
This is a low priority cleanup.
Reviewer Checklist