Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Add missing getblocktemplate-rpcs feature dependencies #5575

Closed
wants to merge 1 commit into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 7, 2022

Motivation

Zebra is missing some getblocktemplate-rpcs feature dependencies.
This might be causing build bugs like #5570.

Solution

Review

This is urgent because these failures are blocking other PRs merging.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures labels Nov 7, 2022
@teor2345 teor2345 self-assigned this Nov 7, 2022
@teor2345 teor2345 requested review from a team as code owners November 7, 2022 23:12
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team November 7, 2022 23:12
@github-actions github-actions bot added the C-feature Category: New features label Nov 7, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #5575 (bb51b82) into main (75f83fc) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5575      +/-   ##
==========================================
- Coverage   78.84%   78.77%   -0.08%     
==========================================
  Files         305      305              
  Lines       38126    38127       +1     
==========================================
- Hits        30061    30033      -28     
- Misses       8065     8094      +29     

@teor2345 teor2345 marked this pull request as draft November 8, 2022 02:38
@teor2345 teor2345 added P-Medium ⚡ and removed P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures C-feature Category: New features labels Nov 8, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Nov 8, 2022

This might actually make CI worse, so we need to fix the underlying error first.

@teor2345
Copy link
Contributor Author

teor2345 commented Nov 8, 2022

These changes are needed for another PR anyway, so I'm just going to close this separate PR, because it doesn't fix anything.

@teor2345 teor2345 closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant