-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(sync): increase the height of blocks for some full sync jobs #5391
Conversation
The checkpoint step took 4-5 hours to get to 1810k blocks (timed out after ~1817k). Adding just one extra step this time. |
33aa305
to
3623582
Compare
ssh failure in
https://github.com/ZcashFoundation/zebra/actions/runs/3236318547/jobs/5302131447#step:6:777 |
There are lots of different ways
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also saw these sync warnings in the logs:
2022-10-11T03:59:58.369043Z WARN {net="Main"}: zebrad::components::sync::progress: chain updates have stalled, state height has not increased for 30 minutes. Hint: check your network connection, and your computer clock and time zone sync_percent=31.016% current_height=Height(572486) network_upgrade=Sapling time_since_last_state_block=30m target_block_spacing=PT75S max_block_spacing=None is_syncer_stopped=false
https://github.com/ZcashFoundation/zebra/actions/runs/3223410431/jobs/5295854595#step:6:2844
Every time they happen, the sync takes half an hour longer waiting for a single block. So maybe we could drop the timeout back down to 10 minutes first?
(We might still need this PR.)
Let's see how #5397 goes, then try this one? There is also a timeout in the Rust test we might need to fix. |
We should definitely fix that first.
It's doubtful it'll make it from 1790k to ~1834k, though we might be able to replace |
@arya2 do we still need this PR? |
Seems like we are still having timeouts in the |
I believe we do, but I'll just quickly check the logs for the timeouts and perhaps replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the regexes might be wrong here?
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
is there a github issue that this is related to that I can link in? |
No, this was ad-hoc and trivial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Mergifyio update |
✅ Branch has been successfully updated |
Motivation
This is the standard fix for when a full sync job runs too long (
logs-checkpoint
needs to sync ~45k blocks as of the latest checkpoint update).Solution
See fixing-ci-sync-timeouts
Review
Anyone can review.
Reviewer Checklist