-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): create Docker hub binaries when tagging #5138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, thanks for pulling it together.
But I'm wondering if triggering releases using a tag filter is confusing or error-prone.
We've never used tags for development - we just seem to use branches.
But if we ever do, it would be a bit hard for developers to remember to start tags with letters other than v
. (And if they forget, their tag gets published as an official release, and everyone using zebrad:latest
automatically gets it.)
Can we use the release events instead?
https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#webhook-payload-object-41
Co-authored-by: teor <teor@riseup.net>
Seems like this needs further testing as this condition is not working as expected . I'm pulling it back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes!
I just went through the comments and made them match what I think is happening. Feel free to edit them or reject them.
I'm happy for anyone to re-approve this PR.
Co-authored-by: teor <teor@riseup.net>
There were a bunch of edge cases, but this is finally ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to check the tags before we merge.
Delete https://github.com/ZcashFoundation/zebra/releases/tag/v1.0.0 when this is approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to format all the version numbers in our tags the same way.
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good!
Motivation
We'd like to have binaries published in Docker Hub for easier pulling, as people is more used to use the
pull <org>/<image>:<tag>
approach when pulling Docker images, instead of long URLs which could also change.Designs
Publish binaries to Docker Hub when we're making a new release.
Solution
Fixes #1963
Review
We might want to be more strict with which tags to release to Docker Hub.
Reviewer Checklist
Follow Up Work
Update #4917 with this information (?)