-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump serde_with from 1.14.0 to 2.0.0 #4785
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4785 +/- ##
==========================================
+ Coverage 78.77% 78.81% +0.04%
==========================================
Files 305 305
Lines 38742 38169 -573
==========================================
- Hits 30518 30084 -434
+ Misses 8224 8085 -139 |
24a45d2
to
9e647c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a lot of changes but it looks fine, and does not seem to break existing code.
But can anyone double-check if this is safe?
@ZcashFoundation/unsafe-rust-reviewers
It pretty much follows the recommended pattern in https://doc.rust-lang.org/nightly/std/mem/union.MaybeUninit.html#initializing-an-array-element-by-element I checked that it drops the correct number of items. (If anyone else wants to check, search the diff for "unsafe", the link didn't take me there automatically.) |
@dependabot recreate |
Bumps [serde_with](https://github.com/jonasbb/serde_with) from 1.14.0 to 2.0.0. - [Release notes](https://github.com/jonasbb/serde_with/releases) - [Commits](jonasbb/serde_with@v1.14.0...v2.0.0) --- updated-dependencies: - dependency-name: serde_with dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
9e647c6
to
60d7c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Bumps serde_with from 1.14.0 to 2.0.0.
Release notes
Sourced from serde_with's releases.
... (truncated)
Commits
625e59a
Merge #491427b025
Bump versions to release v2.0.08ad35a0
Merge #490b1190c0
Cleanup links and attributes12cd92a
Merge #4890534f80
Suppress issue withclippy::explicit_auto_deref
49ebe72
Merge #48769ed4a1
Make theJsonString
smarter6969abf
Merge #4849c2923e
Bump versions to v2.0.0-rc.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)