Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(deps): update locked version of indirect dependency crossbeam-channel to 0.5.4 #4331

Merged
merged 2 commits into from
May 6, 2022
Merged

change(deps): update locked version of indirect dependency crossbeam-channel to 0.5.4 #4331

merged 2 commits into from
May 6, 2022

Conversation

jvff
Copy link
Contributor

@jvff jvff commented May 5, 2022 •
edited by teor2345
Loading

Motivation

The previously locked version (0.5.2) was yanked from crates.io.

Depends-On: #4332

Solution

I ran

cargo update -p crossbeam-channel

to force Cargo to update Cargo.toml to the latest compatible version of crossbeam-channel.

Review

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@jvff
Update crossbeam-channel to 0.5.4
9221abb 
The previously locked version (`0.5.2`) was yanked from `crates.io`.
@jvff jvff requested a review from a team as a code owner May 5, 2022 20:25
@jvff jvff requested review from conradoplg and removed request for a team May 5, 2022 20:25
@jvff jvff self-assigned this May 5, 2022
@jvff jvff added A-dependencies Area: Dependency file updates P-Optional ✨ labels May 5, 2022
@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label May 5, 2022
@teor2345
Copy link
Contributor

teor2345 commented May 5, 2022

Let's wait to merge this until #4332 merges, because otherwise we'll run a lot of full sync tests.

@teor2345 teor2345 added C-security Category: Security issues and removed do-not-merge Tells Mergify not to merge this PR labels May 5, 2022
teor2345
teor2345 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@teor2345
Copy link
Contributor

teor2345 commented May 5, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented May 5, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request May 5, 2022
@mergify
Merge of #4331
4bee867
@mergify mergify bot mentioned this pull request May 5, 2022
Closed
40 tasks
@mergify mergify bot merged commit a2ebc91 into main May 6, 2022
@mergify mergify bot deleted the update-crossbeam-channel branch May 6, 2022 00:35
@conradoplg conradoplg mentioned this pull request May 6, 2022
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@teor2345 teor2345 teor2345 approved these changes

@conradoplg conradoplg Awaiting requested review from conradoplg conradoplg is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@jvff jvff

Labels
A-dependencies Area: Dependency file updates C-security Category: Security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvff @teor2345 @dconnolly