Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): fix confusing environmental variable names in Rust code #4301

Merged
merged 1 commit into from
May 5, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 5, 2022

Motivation

We have Rust variables that store environmental variable names, to detect typos.

But the Rust variables were named differently to the environmental variables, which made them confusing to use.

Solution

fastmod _VAR "" zebra*

Review

Anyone can review this low priority PR.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-Low ❄️ I-usability Zebra is hard to understand or use C-testing Category: These are tests labels May 5, 2022
@teor2345 teor2345 requested a review from a team as a code owner May 5, 2022 01:48
@teor2345 teor2345 removed the request for review from a team May 5, 2022 01:48
@teor2345 teor2345 self-assigned this May 5, 2022
@teor2345 teor2345 requested a review from conradoplg May 5, 2022 01:48
@teor2345 teor2345 changed the title refactor(test): fix confusing Rust "environmental variable name" variable names refactor(test): fix confusing environmental variable names in Rust May 5, 2022
@teor2345 teor2345 changed the title refactor(test): fix confusing environmental variable names in Rust refactor(test): fix confusing environmental variable names in Rust code May 5, 2022
@gustavovalverde
Copy link
Member

@teor2345
Copy link
Contributor Author

teor2345 commented May 5, 2022

@teor2345 isn't this causing the issue in https://github.com/ZcashFoundation/zebra/runs/6299601576?check_suite_focus=true#step:8:221 ?

No, the names of the environmental variables have not changed, only the Rust names have.

This PR is not required.

mergify bot added a commit that referenced this pull request May 5, 2022
mergify bot added a commit that referenced this pull request May 5, 2022
@mergify mergify bot merged commit 7cc8f7e into main May 5, 2022
@mergify mergify bot deleted the confusing-env-vars branch May 5, 2022 05:59
@conradoplg conradoplg mentioned this pull request May 6, 2022
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-testing Category: These are tests I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants