7. feat(db): Add a transparent address transaction index

[conradoplg]

Motivation

Per #3951 we need to index transactions by their destination addresses.

Specifications

Designs

Solution

Create a new column family to map AddressLocation (how we represent Addresses) to TransactionLocations, using RocksDB keys. (It's how we do 1-to-many mappings, for efficiency)

Closes #3951

Review

Based on #3999

I still want to test this more, but I think it's OK for review.

@teor2345 will probably be able to review this quickly, but anyone could do it.

Reviewer Checklist

• Code implements Specs and Designs
• Tests for Expected Behaviour
• Tests for Errors

Follow Up Work

[teor2345]

Looks great!

I think we might need to index transactions that sent or received value from an address, because that's what zcashd does. Can you double-check that for me?

Here is the address index code I found:

• indexing spent: https://github.com/zcash/zcash/blob/c76b756a688bfa0a4396a45355814cdc9f9a47e3/src/main.cpp#L3173-L3183
• indexing received: https://github.com/zcash/zcash/blob/c76b756a688bfa0a4396a45355814cdc9f9a47e3/src/main.cpp#L3228-L3237
• index type: https://github.com/zcash/zcash/blob/49ffee3f20b972dc3aa75e422c67523251cf088b/src/addressindex.h#L91-L98
• RPC query: https://github.com/zcash/zcash/blob/46190bca236757df4979ff6a6e3d2d2d0a2fa8ce/src/rpc/misc.cpp#L1091-L1102

There is a spending field in each index entry, but I couldn't find any code that did a spending filter on the query.

(We can do a video review if that would be helpful.)

[conradoplg]

Started full sync test to check performance

[teor2345]

Looks great, thanks!

[teor2345]

I rebased this PR after rebasing the rest of the PR series.

[teor2345]

The macOS tests failed due to a temporary port conflict:

Message: Opening Zcash network protocol listener 127.0.0.1:58891 failed: Os { code: 48, kind: AddrInUse, message: "Address already in use" }. Hint: Check if another zebrad or zcashd process is running. Try changing the network listen_addr in the Zebra config.

https://github.com/ZcashFoundation/zebra/runs/5999791680?check_suite_focus=true#step:13:1927

I'll re-run that job.

[teor2345]

Error: No such container: klt-regenerate-disk-4038-merge-9969dc2-bfnh

https://github.com/ZcashFoundation/zebra/runs/6007481272?check_suite_focus=true#step:10:115

This is a known issue, I'll retry that check.

[oxarbitrage]

re-approving

[teor2345]

This is still failing, I'm going to temporarily turn off that check to get this PR to merge.
(It has passed before on this PR.)

I opened a ticket here:
#4114