Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get addresses from transparent outputs #3802

Merged
merged 2 commits into from
Mar 11, 2022
Merged

feat: get addresses from transparent outputs #3802

merged 2 commits into from
Mar 11, 2022

Conversation

conradoplg
Copy link
Collaborator

Motivation

For lightwalletd support we need to be able to get the destination address from a transparent output.

Specifications

Designs

Solution

  • Add a Output::address() method that calls zcash_primitives from librustzcash

Closes #3149

Review

Not urgent right now but it blocks other six lightwalletd tickets

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@conradoplg conradoplg requested review from a team as code owners March 8, 2022 20:04
@conradoplg conradoplg requested review from upbqdn and removed request for a team March 8, 2022 20:04
@codecov
Copy link

codecov bot commented Mar 8, 2022 •
edited
Loading

Codecov Report

Merging #3802 (80905ad) into main (44c7b5d) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3802      +/-   ##
==========================================
- Coverage   79.00%   78.83%   -0.17%     
==========================================
  Files         292      292              
  Lines       33311    33601     +290     
==========================================
+ Hits        26317    26491     +174     
- Misses       6994     7110     +116

@conradoplg conradoplg mentioned this pull request Mar 8, 2022
Closed
2 tasks
@teor2345 teor2345 requested review from teor2345 and removed request for a team March 8, 2022 22:51
teor2345
teor2345 reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I'd like to see a bit more test coverage.

teor2345
teor2345 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

mergify bot added a commit that referenced this pull request Mar 10, 2022
@mergify
Merge of #3802
182c11c
This was referenced Mar 10, 2022
Closed
Closed
mergify bot added a commit that referenced this pull request Mar 11, 2022
@mergify
Merge of #3802
c3adbcd
@mergify mergify bot mentioned this pull request Mar 11, 2022
Closed
28 tasks
@mergify mergify bot merged commit 9862f6e into main Mar 11, 2022
@mergify mergify bot deleted the get-address-from-output-new branch March 11, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/cryptographic-reviewers

Assignees

@conradoplg conradoplg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get addresses from transparent outputs
2 participants
@conradoplg @teor2345