-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2. Route peer requests based on missing inventory #3465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
b99d195
to
cb561d3
Compare
8 tasks
Codecov Report
@@ Coverage Diff @@
## main #3465 +/- ##
==========================================
- Coverage 78.34% 78.32% -0.02%
==========================================
Files 267 273 +6
Lines 31526 31807 +281
==========================================
+ Hits 24698 24914 +216
- Misses 6828 6893 +65 |
cb561d3
to
2e7f394
Compare
There is no clippy lint for this, maybe because some macros are sensitive to trailing commas. (But not the ones changed in this commit.)
2e7f394
to
e049a17
Compare
oxarbitrage
previously approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, i just have a minor question.
oxarbitrage
reviewed
Feb 7, 2022
teor2345
commented
Feb 8, 2022
oxarbitrage
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-network
Area: Network protocol updates or fixes
C-enhancement
Category: This is an improvement
C-security
Category: Security issues
I-remote-node-overload
Zebra can overload other nodes on the network
I-slow
Problems with performance or responsiveness
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra needs to stop asking the same peer for the same block multiple times.
Solution
Part of #2156.
Review
@oxarbitrage is reviewing this PR.
Reviewer Checklist
Follow Up Work
notfound
message to the inv collectornotfound
, and use receivednotfound
to finish requests #2726notfound
to peers when Zebra doesn't have a block or transactionnotfound
to finish pending block or transaction requests