Fix Orchard implementation, refactor, and add more test vectors #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
force-pushed
the
orchard-keys-notes-nullifers-test-vectors
branch
from
b0ac7e8 to
c5cb86c
Compare
jvff
previously approved these changes
Jul 6, 2021
teor2345
reviewed
Jul 6, 2021
teor2345
reviewed
Jul 6, 2021
teor2345
reviewed
Jul 6, 2021
teor2345
reviewed
Jul 6, 2021
There was a problem hiding this comment.
I have a few comments about the code, but it mostly looks good.
It looks like this PR contains bug fixes or refactors, as well as tests.
Can you rename this PR so the changelog is accurate?
In future, can we split PRs like this into smaller changes?
It helps keep code reviews more focused.
Maybe we could have done the refactors later, or split the changes by module. But I understand that is not always possible.
conradoplg
reviewed
Jul 14, 2021
teor2345
changed the title
I renamed the PR. |
dconnolly
commented
Jul 15, 2021
conradoplg
reviewed
Jul 15, 2021
There was a problem hiding this comment.
Addressed comments and synced with main.
While syncing I renamed the test_vectors.rs added in #2407 (which was renamed to empty_roots.rs in this PR) to tree.rs (since it now contains empty roots, commitments and resulting roots)
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
jvff
approved these changes
Jul 16, 2021
mpguerra
added a commit
that referenced
this pull request
May 19, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2023
* ZIPs were updated to remove ambiguity, this was tracked in #1267. * #2105 was fixed by #3039 and #2379 was closed by #3069 * #2230 was a duplicate of #2231 which was closed by #2511 * #3235 was obsoleted by #2156 which was fixed by #3505 * #1850 was fixed by #2944, #1851 was fixed by #2961 and #2902 was fixed by #2969 * We migrated to Rust 2021 edition in Jan 2022 with #3332 * #1631 was closed as not needed * #338 was fixed by #3040 and #1162 was fixed by #3067 * #2079 was fixed by #2445 * #4794 was fixed by #6122 * #1678 stopped being an issue * #3151 was fixed by #3934 * #3204 was closed as not needed * #1213 was fixed by #4586 * #1774 was closed as not needed * #4633 was closed as not needed * Clarify behaviour of difficulty spacing Co-authored-by: teor <teor@riseup.net> * Update comment to reflect implemented behaviour Co-authored-by: teor <teor@riseup.net> * Update comment to reflect implemented behaviour when retrying block downloads Co-authored-by: teor <teor@riseup.net> * Update `TODO` to remove closed issue and clarify when we might want to fix Co-authored-by: teor <teor@riseup.net> * Update `TODO` to remove closed issue and clarify what we might want to change in future Co-authored-by: teor <teor@riseup.net> * Clarify benefits of how we do block verification Co-authored-by: teor <teor@riseup.net> * Fix rustfmt errors --------- Co-authored-by: teor <teor@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want our Orchard code in zebra-chain to conform to the independent Python implementation in zcash-hackworks, for confidence in the correctness (or at least agreement in implementation) of our implementation.
Solution
Pull in generated test vectors for:
Resolves #2079
Review
@conradoplg @upbqdn @jvff @teor2345
Reviewer Checklist
Follow Up Work
Wallet/transaction/proof-creation test vectors are out of scope until we build Zebra Client / wallet functionality.