Add HistoryTree struct #2396
Merged
Add HistoryTree struct #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to get @dconnolly to review this PR, feel free to tag me if you have any questions. |
3 tasks
dconnolly
reviewed
Jun 29, 2021
6 tasks
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
dconnolly
reviewed
Jun 29, 2021
|
@conradoplg made some comments and suggestions for you |
conradoplg
commented
Jun 29, 2021
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ZIP-221 specifies a header commitment to a history tree of the previous blocks.
Thie PR adds a HistoryTree struct that keeps track of the history using the
zcash_history.rswrapper of librustzcash.Specifications
Relevant: https://zips.z.cash/zip-0221 (though this is just part of it)
Designs
See #2135 for some design discussion.
Solution
The HistoryTree struct keeps track of the tree, adding blocks, pruning the tree, and computing the root hash.
There are also some changes to
zcash_history.rsthat I only realized were needed when writing this.Review
This was split off from #2301 to reduce its size so it was partially reviewed.
This has no tests because it is tested indirectly by #2301. However I'm thinking of adding some basic tests; feedback is welcome.
@teor2345 may want to finish reviewing it, and @dconnolly may want to take a look to review the future interaction of this code with the note commitment trees.
Reviewer Checklist
Follow Up Work
Part of #2135
Removing blocks will be added in #2378.
Pruning will be refactored in #2377.
Proper Orchard support will be added along with zcash_history support in #2283. Currently it only has the placeholder parameters for the Orchard roots.