Set ZEBRA_SKIP_NETWORK_TESTS using Windows syntax #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Powershell syntax to set ZEBRA_SKIP_NETWORK_TESTS on Windows. Also skip the entire large sync test step on Ubuntu and Windows, because the tests are skipped anyway due to ZEBRA_SKIP_NETWORK_TESTS. This saves some compilation time.
teor2345
added
C-bug
2 tasks
|
Windows CI failed testnet large sync on #1777, and it seems to keep failing, so let's make this critical priority. |
|
The macOS testnet failure will be fixed by #1222 |
|
I'm admin-merging this PR to fix CI failures. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The large sync tests run on Windows, but we want to disable them.
The "Show env vars" CI step prints
ZEBRA_SKIP_NETWORK_TESTS=on Windows, but we expectZEBRA_SKIP_NETWORK_TESTS=1.The
ifcommand should support==,!=, and||, so they are unlikely to be the problem:https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#operators
Solution
Use Powershell syntax to set
ZEBRA_SKIP_NETWORK_TESTSon Windows:https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#environment-files
Also skip the entire large sync test step on Ubuntu and Windows, because the tests are skipped anyway due to
ZEBRA_SKIP_NETWORK_TESTS. This saves some compilation time.Outcome
The
Show env varsstep in this PR outputs:🎉
Review
This review is a high priority if Windows CI keeps failing after #1777.