Make cargo run use zebrad by default
#1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `cargo run` is run in the workspace directory, it can see two executables: - `zebrad` - `zebra_checkpoints` Adding `default-run = "zebrad"` to `zebrad/Cargo.toml` makes the workspace run `zebrad` by default. (Even though it's redundant for the `zebrad` crate itself.)
|
TIL |
yaahc
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
cargo runis run in the workspace directory, it can see two executables:zebradzebra_checkpointsSo it exits with an error, and asks the user to choose one of them.
But
zebradshould be the default - most users don't care aboutzebra_checkpoints.Solution
Adding
default-run = "zebrad"tozebrad/Cargo.tomlmakes the workspace runzebradby default.(
default-runis redundant for thezebradcrate itself.)Review
I think @yaahc knows more about cargo.
This change can be merged at any time.