deps: use Tower 0.4 from git instead of 0.3.1. #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses at least three pain points: - we were affected by bugs that were already fixed in git, but not in the released crate; - we can use service combinators to transform requests and responses; - we can use the hedge middleware. The version in git is still marked as 0.3.1 but these changes will be part of tower 0.4: tower-rs/tower#431
yaahc
previously approved these changes
Sep 21, 2020
hdevalence
force-pushed
the
tower-git
branch
from
caa4bbd
to
81fae9f
Compare
yaahc
approved these changes
Sep 21, 2020
5 tasks
dconnolly
reviewed
Sep 21, 2020
| ), | ||
| // Discover interprets an error as stream termination, | ||
| // so discard any errored connections... | ||
| peerset_rx.filter(|result| future::ready(result.is_ok())), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses at least three pain points:
the released crate;
The version in git is still marked as 0.3.1 but these changes will be
part of tower 0.4: tower-rs/tower#431