Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean module layouts and imports. #37

Closed
hdevalence opened this issue Sep 27, 2019 · 6 comments
Closed

Clean module layouts and imports. #37

hdevalence opened this issue Sep 27, 2019 · 6 comments
Assignees

Comments

@hdevalence
Copy link
Contributor

As we flesh out the code, we're placing things in various parts of the module tree and importing various items from various paths, but as things take a clearer form we will have a better idea of the ideal logical structure of the module tree. Before we do any release, we should do a reorganization pass to ensure that the module tree is conceptually coherent, and probably use re-exports to simplify presentation of the external module components to external crates. However, it may not make sense to do this right now, while things are still in flux.

@hdevalence
Copy link
Contributor Author

Tagged with later because we cannot have encapsulation until more of the parts are in place, and it's useful to be able to drive stuff with the connect stub.

@hdevalence
Copy link
Contributor Author

Poll::Pending -> Poll::Ready

@hdevalence hdevalence removed the later label Oct 23, 2019
@hdevalence
Copy link
Contributor Author

Potential refactorings/cleanups/simplifications:

  • remove the Peer prefix on the contents of the peer module (i.e., peer::Client not peer::PeerClient);

  • move the initialization functions in peer_set.rs into a submodule and just re-export the init function

@hdevalence hdevalence self-assigned this Nov 27, 2019
@hdevalence
Copy link
Contributor Author

Going to start working on this, hoping to slip it in before #118...

This was referenced Nov 27, 2019
@hdevalence
Copy link
Contributor Author

The remaining work for this ticket is to rename structs in the peer_set module.

@dconnolly
Copy link
Contributor

Closed as done (I think???)

teor2345 pushed a commit that referenced this issue Apr 18, 2023
* Tests that the number of nonces is limited

* removes unused constant

* test that it reaches the nonce limit
mergify bot pushed a commit that referenced this issue Apr 18, 2023
…nonce set (#6534)

* Use a stricter connection rate limit for successful inbound peer connections

* Limit the number of nonces in the self-connection nonce set

* Rate-limit failed inbound connections as well

* Justify the sleep and the yield_now

* Use the configured connection limit rather than a constant

* Tests that the number of nonces is limited (#37)

* Tests that the number of nonces is limited

* removes unused constant

* test that it reaches the nonce limit

---------

Co-authored-by: Arya <aryasolhi@gmail.com>
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants