Add support for zcash_script_transparent_output_address() #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
get-address-from-output
branch
2 times, most recently
from
f56a5bb to
f2404ee
Compare
|
Back to draft until recent changes in ZcashFoundation/zcashd#2 are reviewed |
conradoplg
force-pushed
the
get-address-from-output
branch
from
f2404ee to
471ade6
Compare
3 tasks
|
Ready again for review! |
This was referenced Mar 2, 2022
teor2345
approved these changes
Mar 2, 2022
|
I realized the |
conradoplg
added a commit
that referenced
this pull request
Mar 3, 2022
This reverts commit b7801e4.
dconnolly
pushed a commit
that referenced
this pull request
Mar 3, 2022
This reverts commit b7801e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ZcashFoundation/zebra#3148 we need a function to get an address from an output.
This PR:
zcashsubmodule to point to the branch from Add zcash_script_transparent_output_address() to get address from output zcashd#2 . Eventually we can create the PR upstreamzcashdmain branch (from which Add zcash_script_transparent_output_address() to get address from output zcashd#2 was branched off)(We don't need to add a new function since bindgen automatically creates it, and
zcash_scriptis a thin wrapper)This uses
unsafe(though it's fairly straightforward) so it would be nice to have two reviews.