-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0 #45
Comments
How do you feel about pushing out a minor release with the changes before the |
Yeah would be appreciated. I realised we're still on the git dependency (for #34), and I'm not sure if the |
Thanks! Appreciate it :) |
@FintanH I'm scheduling a release within the next week or so. 📦 |
Amazing, thanks @dconnolly! 🙇 |
@dconnolly: did you ever get around to that release? 👀 Just remembered this after figuring out why some types were different across builds 😅 |
Same question, I know life gets busy sometimes! Is main in a good state for a release? |
You could also consider using |
@gilescope @FintanH @kim 3.0.0 has been tagged: |
This has now been published on crates.io: https://crates.io/crates/ed25519-zebra/3.0.0 Apologies for the delay! 😅 |
Amazing, thanks @dconnolly! ❤️ |
ed25519-zebra has updated to 3.0.0[0]. radicle-keystore was bumped to use this version, which also required rand to be updated too. This patch updates radicle-keystore as well as ed25519-zebra and rand, in the same manner. This means we don't pin the dependency of ed25519-zebra to the git repository. Which means we can also remove it from the deny.toml entry. [0]: ZcashFoundation/ed25519-zebra#45 (comment) Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
You could also consider using ed25519-consensus, a general-purpose fork of the library: https://docs.rs/ed25519-consensus/1.0.0/ed25519_consensus/index.html
I find this rather concerning, particularly because only one side of the story is visible from the outside. Can we get some semi-official statement from ZF ***@***.***), respectively the “other maintainer” of dalek crypto ***@***.***) on what we are supposed to think of this?
|
Upgrading to rand 0.8 / rand_core 0.6 (#40) makes our public api incompatible with 2.0.
The text was updated successfully, but these errors were encountered: