Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0 #45

Closed
dconnolly opened this issue Mar 30, 2021 · 15 comments
Closed

Release 3.0 #45

dconnolly opened this issue Mar 30, 2021 · 15 comments
Assignees

Comments

@dconnolly
Copy link
Contributor

Upgrading to rand 0.8 / rand_core 0.6 (#40) makes our public api incompatible with 2.0.

@kim
Copy link
Contributor

kim commented Apr 12, 2021

How do you feel about pushing out a minor release with the changes before the rand upgrade?

@teor2345
Copy link
Contributor

How do you feel about pushing out a minor release with the changes before the rand upgrade?

The Zeroize (#34) and JNI (#37) changes?

Happy to do that if it would be helpful. Releases don't take a lot of effort - we just need to make time for them.

@kim
Copy link
Contributor

kim commented Apr 15, 2021

Yeah would be appreciated. I realised we're still on the git dependency (for #34), and I'm not sure if the rand upgrade would have effects on other dependencies. Thanks!

@FintanH
Copy link
Contributor

FintanH commented Aug 19, 2021

Hey @teor2345 👋 I wanted to ping about the above minor release. We're still pinning on #34 and it'd be nice to pin to a version. Anything I could do to help? 😊

@teor2345
Copy link
Contributor

Hey @teor2345 👋 I wanted to ping about the above minor release. We're still pinning on #34 and it'd be nice to pin to a version. Anything I could do to help? 😊

I'll check with the team in our meeting next Tuesday, we should have an answer for you by then.

@FintanH
Copy link
Contributor

FintanH commented Aug 26, 2021

I'll check with the team in our meeting next Tuesday, we should have an answer for you by then.

Thanks! Appreciate it :)

@dconnolly
Copy link
Contributor Author

@FintanH I'm scheduling a release within the next week or so. 📦

@FintanH
Copy link
Contributor

FintanH commented Aug 31, 2021

Amazing, thanks @dconnolly! 🙇

@FintanH
Copy link
Contributor

FintanH commented Sep 15, 2021

@dconnolly: did you ever get around to that release? 👀 Just remembered this after figuring out why some types were different across builds 😅

@gilescope
Copy link

Same question, I know life gets busy sometimes! Is main in a good state for a release?

@hdevalence
Copy link
Contributor

You could also consider using ed25519-consensus, a general-purpose fork of the library: https://docs.rs/ed25519-consensus/1.0.0/ed25519_consensus/index.html

@dconnolly
Copy link
Contributor Author

@dconnolly
Copy link
Contributor Author

@gilescope @FintanH @kim 3.0.0 has been tagged: https://github.com/ZcashFoundation/ed25519-zebra/releases/tag/3.0.0

This has now been published on crates.io: https://crates.io/crates/ed25519-zebra/3.0.0

Apologies for the delay! 😅

@FintanH
Copy link
Contributor

FintanH commented Oct 13, 2021

Amazing, thanks @dconnolly! ❤️

xla pushed a commit to radicle-dev/radicle-link that referenced this issue Oct 14, 2021
ed25519-zebra has updated to 3.0.0[0]. radicle-keystore was bumped to
use this version, which also required rand to be updated too.

This patch updates radicle-keystore as well as ed25519-zebra and rand, in
the same manner. This means we don't pin the dependency of ed25519-zebra
to the git repository. Which means we can also remove it from the
deny.toml entry.

[0]: ZcashFoundation/ed25519-zebra#45 (comment)

Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
@kim
Copy link
Contributor

kim commented Oct 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants