Fixes deprecation warnings for ember-data beta.15 #111
Conversation
…t to dev deps; Signed-off-by: Sam Heuck <sam@samheuck.com>
Signed-off-by: Sam Heuck <sam@samheuck.com>
Signed-off-by: Sam Heuck <sam@samheuck.com>
Signed-off-by: Sam Heuck <sam@samheuck.com>
Signed-off-by: Sam Heuck <sam@samheuck.com>
|
Absolutely agreed with you about start using That would be great to collaborate on that with you. Just let me know what you do think about collaboration. Will review this PR and thank you again for help. |
|
Yeah I’d love to collaborate on this - I’m using it for a pet side project, and so that I can keep up with the changes in ember-data. Would you consider converting the project from CoffeeScript to javascript? I’m not very familiar with CofeeScript. It’s not too big a deal if that’s not something you want to do, I can learn CoffeeScript, I would just be better able to contribute. |
|
The project tests are completely outdated. Firstly, I believe we should refresh/review them, #112. Let's discuss it. |
| @@ -115,30 +115,31 @@ window.setupStore = (options) -> | |||
| env = {} | |||
|
|
|||
| options = options or {} | |||
| container = env.container = new Ember.Container() | |||
| registry = new Ember.Registry(options) | |||
There was a problem hiding this comment.
Could you please provide your Ember version? Well, all my tests are failed due to switching to Ember.Registry instead of using Ember.Container as first is undefined on 1.8.1.
There was a problem hiding this comment.
I was using 1.11.0 for the test suite
|
Pushed |
|
Could you please resolve conflicts and make sure that PR is available for merge. Thanks. |
|
Should be good to go. |
|
Well done. Will check this one asap |
Fixes deprecation warnings for ember-data beta.15
This project may want to start using semver - I'm pretty sure these changes are not backward compatible with earlier versions of ember-data. Doing that would mean ember and ember-data would need to be listed as a dev dependencies in bower.json.
There is also a failing test with the revision adapter - will create a separate issue for that.