Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor /server/team-validator-async.js to Typescript #5528

Closed
asingh04 opened this issue Jun 9, 2019 · 3 comments
Closed

Refactor /server/team-validator-async.js to Typescript #5528

asingh04 opened this issue Jun 9, 2019 · 3 comments

Comments

@asingh04
Copy link

asingh04 commented Jun 9, 2019 •
edited by Zarel
Loading

The above mentioned file is to be migrated/refactor to /server/team-validation-async.ts file, using Typescript
@asingh04 asingh04 mentioned this issue Jun 9, 2019
Open
@scheibo scheibo changed the title Refractor /server/team-validator-async.js to Typescript Refactor /server/team-validator-async.js to Typescript Jun 9, 2019
@Zarel
Copy link
Member

Zarel commented Jun 12, 2019

I suppose this is fine to announce you're working on this, but to be clear, it's not required. Do you know how long you'll take to make the PR?

@asingh04
Copy link
Author

@Zarel I will be able to dedicate to this on weekends (Saturdays & Sundays), so I think i should be able to come up with the PR after 2 weeks, as I have to go through and understand the conventions and procedure for writing the .ts file.

@AnnikaCodes
Copy link
Collaborator

This was done in #5987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zarel @asingh04 @AnnikaCodes