Fix log filter URL state infinite loop

Zacqary · Dec 20, 2019 · 43302b3 · 43302b3
1 parent a7fe3ef
commit 43302b3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx b/x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx
@@ -32,7 +32,11 @@ export const useLogFilterUrlState = () => {
   });
 
   /* eslint-disable react-hooks/exhaustive-deps */
-  useEffect(() => applyLogFilterQuery(logFilterUrlState.expression), [logFilterUrlState]);
+  useEffect(() => {
+    if (logFilterUrlState && filterQueryAsKuery?.expression !== logFilterUrlState.expression) {
+      applyLogFilterQuery(logFilterUrlState.expression);
+    }
+  }, [logFilterUrlState]);
   useEffect(() => setLogFilterUrlState(filterQueryAsKuery), [filterQueryAsKuery]);
   /* eslint-enable react-hooks/exhaustive-deps */
 };