Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmp/recheck func #34

Merged
merged 11 commits into from
May 14, 2024
Merged

Tmp/recheck func #34

merged 11 commits into from
May 14, 2024

Conversation

JernKunpittaya
Copy link
Collaborator

@JernKunpittaya JernKunpittaya commented May 10, 2024

Revisit and fix zkstats lib

-param_visibility in settings: change from 'private' to 'fixed' to enforce exact same onnx file for prover and verifier
-introduce precal_witness as a file to store all precalculated witness from prover (i.e. the precalculated result & other intermediates), then when the verifier generates their model, it just hardcodes these precalculated_witness into it.
-With reasons above, we change the flow to be as shown in Readme and all examples in 'examples' folder.
-Remove some uses of torch.tensor() since this basically ignore everything inside and treat it as just a constant. So, can only use it when variable inside () is a constant.
-Delete Where class since we wont include where as precalculated_witness since that will leak too much information
-MagicNumber uses 99.999 instead of 9999999 to avoid blow up
-Make sure our op.result can be transformed into keras
-Make sure computation_to_model always return bool, result format even though we dont use State
-Make default value argument make sense as None: op_dict in ops.py never changes value inside ops.py

tests/test_computation.py Show resolved Hide resolved
zkstats/ops.py Outdated Show resolved Hide resolved
zkstats/ops.py Show resolved Hide resolved
@JernKunpittaya JernKunpittaya merged commit 54972b7 into main May 14, 2024
1 check passed
@JernKunpittaya JernKunpittaya deleted the tmp/recheck_func branch May 22, 2024 04:22
This was referenced May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants