Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace bigint with node-int64 #316

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Conversation

lechuhuuha
Copy link

@lechuhuuha lechuhuuha commented May 24, 2024

This is an attempt to add support for broofa/node-int64.

Summary from this reply:

  • Use node-int64 instead of big-integer
  • After that performance was increased x20 for large files. (11mb - ~9sec).

If merged, this PR should resolve #38 and #224

@ZJONSSON
Copy link
Owner

Thanks, @lechuhuuha. Can you clean this PR up (remove the extra newlines) and also remove big-integer from package.json if it's no longer required?

@lechuhuuha
Copy link
Author

Yes i will do that
Thanks for point its out

@lechuhuuha
Copy link
Author

I had editted the PR
You can check it out @ZJONSSON.

Thanks

@ZJONSSON ZJONSSON merged commit 760f100 into ZJONSSON:master Jun 8, 2024
9 checks passed
@ZJONSSON
Copy link
Owner

ZJONSSON commented Jun 8, 2024

Thanks @lechuhuuha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unzipping very slow for 285 kb file
2 participants