Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing zip64 extra field #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kinolaev
Copy link

@kinolaev kinolaev commented Jul 8, 2020

Hello,

fields can be omitted in the zip64 extra field, see https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT, 4.5.3.

Thank you for great work!

@mrbabbs
Copy link

mrbabbs commented Jul 18, 2020

@ZJONSSON it would be nice if you can merge this PR.
I have tested on node version 12 and fix for me the problem of extracting a file > 4 GB.

@amsoedal
Copy link

amsoedal commented Aug 3, 2020

@ZJONSSON we believe this would fix the FILE_ENDED issue we are seeing as well. Would it be possible to have it looked at? Thanks!
Edit: looks like one of the build jobs is failing?

@theill
Copy link

theill commented Mar 28, 2021

@ZJONSSON - It would be awesome to have this PR merged. We've tested it extensively and running it in production.

@mtinnes
Copy link

mtinnes commented Aug 3, 2021

Any chance this can get merged soonish? please and ty

@pgbce
Copy link

pgbce commented Sep 10, 2021

@ZJONSSON any chance of merging this in? This would be quite helpful. Please

@anderson-arlen
Copy link

@kinolaev Thanks for this. This fixes FILE_ENDED issues I'm having.

@ZJONSSON Please merge this.

nosferatu500 added a commit to nosferatu500/unzipper that referenced this pull request May 9, 2022
@yocontra
Copy link

yocontra commented Jun 5, 2022

@kinolaev Is this fixed by #244 or does it still need to be applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants