Merge pull request #18 from ZEXSM/bugfix/boolean-values

bugfix/boolean values
ZEXSM · Aug 19, 2019 · f5738f3 · f5738f3
2 parents ca80536 + 729e707
commit f5738f3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/OData.QueryBuilder/Extensions/ExpressionExtension.cs b/src/OData.QueryBuilder/Extensions/ExpressionExtension.cs
@@ -215,7 +215,12 @@ public static string ToODataQuery(this Expression expression, string queryString
                             return $"'{memberExpressionValue}'";
                         }
 
-                        return memberExpressionValue.ToString();
+                        if (memberExpressionValue is bool)
+                        {
+                            return $"{memberExpressionValue}".ToLower();
+                        }
+
+                        return $"{memberExpressionValue}";
                     }
 
                     var parentMemberExpressionQuery = memberExpression.Expression.ToODataQuery(queryString);

diff --git a/test/OData.QueryBuilder.Test/ODataQueryBuilderByListTest.cs b/test/OData.QueryBuilder.Test/ODataQueryBuilderByListTest.cs
@@ -258,13 +258,19 @@ public void ODataQueryBuilderList_Operator_In_Empty_Success()
         [Fact(DisplayName = "(ODataQueryBuilderList) Filter boolean values => Success")]
         public void ODataQueryBuilderList_Filter_Boolean_Values_Success()
         {
+            var constValue = false;
+            var newObject = new ODataTypeEntity { IsOpen = false };
+
             var uri = _odataQueryBuilder
                 .For<ODataTypeEntity>(s => s.ODataType)
                 .ByList()
-                .Filter(s => s.IsActive && s.IsOpen == true && s.ODataKind.ODataCode.IdActive == false)
+                .Filter(s => s.IsActive
+                    && s.IsOpen == constValue
+                    && s.IsOpen == true
+                    && s.ODataKind.ODataCode.IdActive == newObject.IsOpen)
                 .ToUri();
 
-            uri.OriginalString.Should().Be("http://mock/odata/ODataType?$filter=IsActive and IsOpen eq true and ODataKind/ODataCode/IdActive eq false");
+            uri.OriginalString.Should().Be("http://mock/odata/ODataType?$filter=IsActive and IsOpen eq false and IsOpen eq true and ODataKind/ODataCode/IdActive eq false");
         }
 
         [Fact(DisplayName = "(ODataQueryBuilderList) Filter brackets => Success")]