Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow Launcher check box clickable areas (address issue #2558) #2559

Merged
merged 1 commit into from
May 27, 2024

Conversation

Acts19quiz
Copy link

Fix issue #2558 by narrowing the Launcher check box clickable areas on their right edges. They extend too far to the extent that clicking on some check boxes will actually change the values of the boxes to their immediate left.

160 is chosen to not only eliminate this overlap, but provide a few extra pixels of buffer space in case of mis-clicks five or so pixels to the left of the intended check box (so that they don't accidentally change the boxes to the left).

@RicardoLuis0
Copy link
Collaborator

have you checked if the new size is wide enough for all translations?

@Acts19quiz
Copy link
Author

Interesting note about that (all translations).

g12_Launcher_new_size
Here's the size as I've narrowed it. The collision boxes no longer overlap, and there's a tiny bit of wiggle room to the left of the check boxes in case of mis-clicks.

Since it was brought up, and for reference, here's what happens with other translations:
g12_Launcher_language_edit
It makes no difference--the visual areas are the same width, and the longer text strings in some translations causes text clipping. That's an entirely separate issue, but I don't know how to fix that short of redesigning the launcher altogether to be wider and accommodate other languages' wider strings. That's another issue for another time, of course. Here, this just addresses the issue of clicking on one column of check boxes affecting the fields to its left.

@RicardoLuis0
Copy link
Collaborator

seems good then

@RicardoLuis0 RicardoLuis0 merged commit c707b41 into ZDoom:master May 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants