Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some code cleaning and complexity improvements #7133

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

zapashcanon
Copy link
Contributor

Hi,

I was reading the code and decided to do three things:

  • clean code with things should not be controversial and are clear improvements (first commit and second commit)
  • fix the complexity of a few operations (the List.filteri and List.compare_length_with changes), one of them was quadratic for no good reason (second commit)
  • explicit some parameters, this allows to get less false positives warnings of the kind "this argument will not be used by the function" when one still wants to enable warnings in its editor without having propoer support through the dune build system, this may be more controversial and I'm fine with removing it (third commit)

Thanks!

src/api/ml/z3.ml Outdated Show resolved Hide resolved
@zapashcanon
Copy link
Contributor Author

@microsoft-github-policy-service agree company="OCamlPro"

@NikolajBjorner NikolajBjorner merged commit 91886da into Z3Prover:master Feb 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants