remove default destructors & some default constructors

Another ~700 KB reduction in binary size

src/ackermannization/lackr_model_constructor.cpp

@@ -41,8 +41,6 @@ struct lackr_model_constructor::imp {
         , m_ackr_helper(m)
     {}
 
-    ~imp() { }
-
     //
     // Returns true iff model was successfully constructed.
     // Conflicts are saved as a side effect.

src/ast/ast_pp_dot.cpp

@@ -45,8 +45,6 @@ struct ast_pp_dot_st {
         m_printed(),
         m_to_print(),
         m_first(true) {}
-
-    ~ast_pp_dot_st() {};
 
     void push_term(const expr * a) { m_to_print.push_back(a); }        
 

src/ast/euf/euf_ac_plugin.h

@@ -47,7 +47,6 @@ namespace euf {
             unsigned_vector eqs;       // equality occurrences
 
             unsigned root_id() const { return root->n->get_id(); }
-            ~node() {}
             static node* mk(region& r, enode* n);
         };
 
@@ -270,8 +269,6 @@ namespace euf {
         ac_plugin(egraph& g, unsigned fid, unsigned op);
 
         ac_plugin(egraph& g, func_decl* f);
-
-        ~ac_plugin() override {}
 
         theory_id get_id() const override { return m_fid; }
 

src/ast/euf/euf_arith_plugin.h

@@ -33,8 +33,6 @@ namespace euf {
     public:
         arith_plugin(egraph& g);
 
-        ~arith_plugin() override {}
-
         theory_id get_id() const override { return a.get_family_id(); }
 
         void register_node(enode* n) override;

src/ast/euf/euf_bv_plugin.h

@@ -95,8 +95,6 @@ namespace euf {
     public:
         bv_plugin(egraph& g);
 
-        ~bv_plugin() override {}
-
         theory_id get_id() const override { return bv.get_family_id(); }
 
         void register_node(enode* n) override;

src/ast/euf/euf_specrel_plugin.h

@@ -34,8 +34,6 @@ namespace euf {
     public:
 
         specrel_plugin(egraph& g);
-
-        ~specrel_plugin() override {}
 
         theory_id get_id() const override { return sp.get_family_id(); }
 

src/ast/rewriter/label_rewriter.cpp

@@ -26,8 +26,6 @@ label_rewriter::label_rewriter(ast_manager & m) :
     m_label_fid(m.get_label_family_id()),
     m_rwr(m, false, *this) {}
 
-label_rewriter::~label_rewriter() {}
-
 br_status label_rewriter::reduce_app(
     func_decl * f, unsigned num, expr * const * args, expr_ref & result, 
     proof_ref & result_pr) {

src/ast/rewriter/label_rewriter.h

@@ -27,7 +27,6 @@ class label_rewriter : public default_rewriter_cfg {
     rewriter_tpl<label_rewriter> m_rwr;
 public:    
     label_rewriter(ast_manager & m);
-    ~label_rewriter();
 
     br_status reduce_app(func_decl * f, unsigned num, expr * const * args, expr_ref & result, 
                          proof_ref & result_pr);

src/ast/rewriter/rewriter.h

@@ -346,8 +346,6 @@ class rewriter_tpl : public rewriter_core {
     ast_manager & m() const { return this->m_manager; }
     Config & cfg() { return m_cfg; }
     Config const & cfg() const { return m_cfg; }
-
-    ~rewriter_tpl() override {};
 
     void reset();
     void cleanup();

src/ast/simplifiers/reduce_args_simplifier.cpp

@@ -375,8 +375,6 @@ class reduce_args_simplifier : public dependent_expr_simplifier {
         m_bv(m)
     {}
 
-    ~reduce_args_simplifier() override {}
-
     char const* name() const override { return "reduce-args"; }
 
     void collect_statistics(statistics& st) const override {

src/muz/base/rule_properties.cpp

@@ -31,8 +31,6 @@ rule_properties::rule_properties(ast_manager & m, rule_manager& rm, context& ctx
     m_dt(m), m_dl(m), m_a(m), m_bv(m), m_ar(m), m_rec(m), 
     m_generate_proof(false), m_collected(false), m_is_monotone(true) {}
 
-rule_properties::~rule_properties() {}
-
 void rule_properties::collect(rule_set const& rules) {
     reset();
     m_collected = true;

src/muz/base/rule_properties.h

@@ -58,7 +58,6 @@ namespace datalog {
         bool check_accessor(app* n);
     public:
         rule_properties(ast_manager & m, rule_manager& rm, context& ctx, i_expr_pred& is_predicate);
-        ~rule_properties();    
         void set_generate_proof(bool generate_proof) { m_generate_proof = generate_proof; } 
         void collect(rule_set const& r);
         void check_quantifier_free();

src/muz/bmc/dl_bmc_engine.cpp

@@ -1443,8 +1443,6 @@ namespace datalog {
         m_rule_trace(ctx.get_rule_manager()) {
     }
 
-    bmc::~bmc() {}
-
     lbool bmc::query(expr* query) {
         m_solver = nullptr;
         m_answer = nullptr;

src/muz/bmc/dl_bmc_engine.h

@@ -51,8 +51,6 @@ namespace datalog {
     public:
         bmc(context& ctx);
 
-        ~bmc() override;
-
         lbool query(expr* query) override;
 
         void display_certificate(std::ostream& out) const override;

src/muz/clp/clp_context.cpp

@@ -59,8 +59,6 @@ namespace datalog {
             m_fparams.m_mbqi = false;
         }
 
-        ~imp() {}        
-
         lbool query(expr* query) {
             m_ctx.ensure_opened();
             m_solver.reset();

src/muz/ddnf/ddnf.cpp

@@ -78,8 +78,6 @@ namespace datalog {
             m_descendants(DEFAULT_HASHTABLE_INITIAL_CAPACITY, m_hash, m_eq) {
         }
 
-        ~ddnf_node() {}
-
         unsigned inc_ref() {
             return ++m_refs;
         }
@@ -429,8 +427,6 @@ namespace datalog {
     class ddnfs {
         u_map<ddnf_mgr*> m_mgrs;
     public:
-        ddnfs() {}
-
         ~ddnfs() {
             u_map<ddnf_mgr*>::iterator it = m_mgrs.begin(), end = m_mgrs.end();
             for (; it != end; ++it) {
@@ -503,8 +499,6 @@ namespace datalog {
             m_inner_ctx.updt_params(params);
         }
 
-        ~imp() {}        
-
         lbool query(expr* query) {
             m_ctx.ensure_opened();
             rule_set& old_rules = m_ctx.get_rules();

src/muz/spacer/spacer_expand_bnd_generalizer.h

@@ -43,7 +43,6 @@ class lemma_expand_bnd_generalizer : public lemma_generalizer {
 
   public:
     lemma_expand_bnd_generalizer(context &ctx);
-    ~lemma_expand_bnd_generalizer() override {}
 
     void operator()(lemma_ref &lemma) override;
 

src/muz/spacer/spacer_global_generalizer.h

@@ -161,7 +161,6 @@ class lemma_global_generalizer : public lemma_generalizer {
 
   public:
     lemma_global_generalizer(context &ctx);
-    ~lemma_global_generalizer() override {}
 
     void operator()(lemma_ref &lemma) override;
 

src/muz/tab/tab_context.cpp

@@ -1354,8 +1354,6 @@ namespace datalog {
             m_fparams.m_mbqi = false;
         }
 
-        ~imp() {}
-
         lbool query(expr* query) {
             m_ctx.ensure_opened();
             m_index.reset();

src/muz/transforms/dl_mk_array_eq_rewrite.h

@@ -40,7 +40,6 @@ namespace datalog {
      public:
         mk_array_eq_rewrite(context & ctx, unsigned priority);
         rule_set * operator()(rule_set const & source) override;
-        ~mk_array_eq_rewrite() override{}
     };
 
 

src/muz/transforms/dl_mk_array_instantiation.h

@@ -112,7 +112,6 @@ namespace datalog {
      public:
         mk_array_instantiation(context & ctx, unsigned priority);
         rule_set * operator()(rule_set const & source) override;
-        ~mk_array_instantiation() override{}
     };
 
 

src/muz/transforms/dl_mk_backwards.cpp

@@ -27,8 +27,6 @@ namespace datalog {
         m(ctx.get_manager()),
         m_ctx(ctx) {        
     }
-
-    mk_backwards::~mk_backwards() { }
 
     rule_set * mk_backwards::operator()(rule_set const & source) {
         context& ctx = source.get_context();

src/muz/transforms/dl_mk_backwards.h

@@ -27,7 +27,6 @@ namespace datalog {
         context&     m_ctx;
     public:
         mk_backwards(context & ctx, unsigned priority = 33000);
-        ~mk_backwards() override;
         rule_set * operator()(rule_set const & source) override;
     };
 

src/muz/transforms/dl_mk_bit_blast.cpp

@@ -146,8 +146,6 @@ namespace datalog {
             m_dst(nullptr)
         {}
 
-        ~expand_mkbv_cfg() {}
-
         void set_src(rule_set const* src) { m_src = src; }
         void set_dst(rule_set* dst) { m_dst = dst; }
         func_decl_ref_vector const& old_funcs() const { return m_old_funcs; }

src/muz/transforms/dl_mk_elim_term_ite.cpp

@@ -80,8 +80,6 @@ namespace datalog {
         rm(ctx.get_rule_manager()),
         m_ground(m) {}
 
-    mk_elim_term_ite::~mk_elim_term_ite() {}
-
     /**
        \brief map free variables in e to ground, fresh, constants
        m_ground is reset on every new rule so it is safe to assume

src/muz/transforms/dl_mk_elim_term_ite.h

@@ -35,7 +35,6 @@ namespace datalog {
         expr_ref ground(expr* e);
     public:
         mk_elim_term_ite(context &ctx, unsigned priority);
-        ~mk_elim_term_ite() override;
         rule_set * operator()(const rule_set &source) override;
     };
 }

src/muz/transforms/dl_mk_karr_invariants.cpp

@@ -58,8 +58,6 @@ namespace datalog {
             m_inner_ctx.updt_params(params);
     }
 
-    mk_karr_invariants::~mk_karr_invariants() { }
-
     void matrix::display_row(
         std::ostream& out, vector<rational> const& row, rational const& b, bool is_eq) {
         for (unsigned j = 0; j < row.size(); ++j) {

src/muz/transforms/dl_mk_karr_invariants.h

@@ -62,8 +62,6 @@ namespace datalog {
         rule_set* update_rules(rule_set const& src);
     public:
         mk_karr_invariants(context & ctx, unsigned priority);
-
-        ~mk_karr_invariants() override;
 
         rule_set * operator()(rule_set const & source) override;
 

src/muz/transforms/dl_mk_loop_counter.cpp

@@ -30,8 +30,6 @@ namespace datalog {
         m_refs(m) {        
     }
 
-    mk_loop_counter::~mk_loop_counter() { }
-
     app_ref mk_loop_counter::add_arg(rule_set const& src, rule_set& dst, app* fn, unsigned idx) {
         expr_ref_vector args(m);
         func_decl* new_fn, *old_fn = fn->get_decl();

src/muz/transforms/dl_mk_loop_counter.h

@@ -35,7 +35,6 @@ namespace datalog {
         app_ref del_arg(app* fn);        
     public:
         mk_loop_counter(context & ctx, unsigned priority = 33000);
-        ~mk_loop_counter() override;
 
         rule_set * operator()(rule_set const & source) override;
 

src/muz/transforms/dl_mk_magic_symbolic.cpp

@@ -63,8 +63,6 @@ namespace datalog {
         m(ctx.get_manager()),
         m_ctx(ctx) {        
     }
-
-    mk_magic_symbolic::~mk_magic_symbolic() { }
 
     rule_set * mk_magic_symbolic::operator()(rule_set const & source) {
         if (!m_ctx.magic()) {

src/muz/transforms/dl_mk_magic_symbolic.h

@@ -29,7 +29,6 @@ namespace datalog {
         app_ref      mk_query(app* q);
     public:
         mk_magic_symbolic(context & ctx, unsigned priority = 33037);
-        ~mk_magic_symbolic() override;
         rule_set * operator()(rule_set const & source) override;
     };
 

src/qe/mbp/mbp_arith.cpp

@@ -43,8 +43,6 @@ namespace mbp {
         imp(ast_manager& m) :
             m(m), a(m) {}
 
-        ~imp() {}
-
         void insert_mul(expr* x, rational const& v, obj_map<expr, rational>& ts) {
             rational w;
             if (ts.find(x, w))

src/qe/mbp/mbp_arrays.cpp

@@ -1058,7 +1058,6 @@ namespace mbp {
         scoped_ptr<contains_app> m_var;
 
         imp(ast_manager& m): m(m), a(m), m_stores(m) {}
-        ~imp() {}
 
         bool solve(model& model, app_ref_vector& vars, expr_ref_vector& lits) {
             return false;

src/qe/mbp/mbp_term_graph.cpp

@@ -187,8 +187,6 @@ class term {
         m_is_peq = is_partial_eq(to_app(m_expr));
     }
 
-    ~term() {}
-
     class parents {
         term const &t;
 

src/qe/nlqsat.cpp

@@ -558,7 +558,6 @@ namespace qe {
             vector<div>   m_divs;
         public:
             div_rewriter_cfg(nlqsat& s): m(s.m), a(s.m), m_zero(a.mk_real(0), m) {}
-            ~div_rewriter_cfg() {}
             br_status reduce_app(func_decl* f, unsigned sz, expr* const* args, expr_ref& result, proof_ref& pr) {
                 rational r1, r(1);
                 if (a.is_div(f) && sz == 2 && a.is_numeral(args[0], r1) && a.is_numeral(args[1], r) && !r.is_zero()) {

src/sat/sat_model_converter.h

@@ -58,7 +58,6 @@ namespace sat {
                 m_stack(std::move(stack)) {
                 m_counter = ++counter;
             }
-            ~elim_stack() { }
             void inc_ref() { ++m_refcount; }
             void dec_ref() { if (0 == --m_refcount) { dealloc(this); } }
             elim_stackv const& stack() const { return m_stack; }

src/sat/sat_mus.cpp

@@ -24,8 +24,6 @@ Module Name:
 namespace sat {
 
     mus::mus(solver& s):s(s), m_is_active(false), m_max_num_restarts(UINT_MAX) {}
-
-    mus::~mus() {}
 
     void mus::reset() {
         m_core.reset();

src/sat/sat_mus.h

@@ -30,7 +30,6 @@ namespace sat {
 
     public:
         mus(solver& s);
-        ~mus();        
         lbool operator()();
         bool is_active() const { return m_is_active; }
         model const& get_model() const { return m_model; }

src/sat/smt/arith_sls.h

@@ -153,7 +153,6 @@ namespace arith {
 
     public:
         sls(solver& s);
-        ~sls() override {}
         void set(sat::ddfw* d);
         void init_search() override;
         void finish_search() override;

src/sat/smt/array_solver.cpp

@@ -88,8 +88,6 @@ namespace array {
         m_constraint->initialize(m_constraint.get(), this);
     }
 
-    solver::~solver() {}
-
     sat::check_result solver::check() {
         force_push();
         // flet<bool> _is_redundant(m_is_redundant, true);

src/sat/smt/array_solver.h

@@ -268,7 +268,6 @@ namespace array {
         void validate_extensionality(euf::enode* s, euf::enode* t) const;
     public:
         solver(euf::solver& ctx, theory_id id);
-        ~solver() override;
         bool is_external(bool_var v) override { return false; }
         void get_antecedents(literal l, sat::ext_justification_idx idx, literal_vector& r, bool probing) override {}
         void asserted(literal l) override {}

src/sat/smt/intblast_solver.h

@@ -103,8 +103,6 @@ namespace intblast {
 
     public:
         solver(euf::solver& ctx);
-
-        ~solver() override {}
 
         lbool check_axiom(sat::literal_vector const& lits);
         lbool check_core(sat::literal_vector const& lits, euf::enode_pair_vector const& eqs);