Implement AS 16 Find command to fix e-mail search on iOS 16+ #57

[mschering]

What does this implement/fix? Explain your changes.

iOS 16 and up wrongfully sends a Find command when searching mail using Z-Push. I implemented the Find command so that searching works on iOS 16.

Does this close any currently open issues?

Fixes Error when searching mail on iphone #23

Any relevant logs, error output, etc?

No

Where has this been tested?

Server (please complete the following information):

• OS: Linux
• PHP Version: 8.2
• Backend for: Group-Office
• and Version: 6.8

Smartphone (please complete the following information):

• Device: IPhone 13
• OS: iOS 17.4
• Mail App Apple mail

[matidau]

After my last PR merge this now has conflicts can you review and update?

[mschering]

It looks like your merge makes my pull request obsolete doesn't it? It implements the same thing it seems.

[mschering]

I fixed the conflicts. the file find.php was difficult to merge. I took my version and used the SYNC_* constants like you did.

[matidau]

Sorry I haven't responded earlier. Really appreciate your work on this.

It looks like your merge makes my pull request obsolete doesn't it? It implements the same thing it seems.
Yep it does implement something very similar but maybe with different aims, I was implementing to get Kopano backend working before moving on to the other backends for AS16.

I don't have an iPhone so no way of knowing if my changes will work in general or for AS14 backends.

I fixed the conflicts. the file find.php was difficult to merge. I took my version and used the SYNC_* constants like you did.
👍

I'm not sure if you are in a position to test this with the Imap backend, but I'll shout out in the issue if someone is able to test.

[matidau]

Will be able to test this soon, I've got an iPhone XS with the latest version of iOS on the way.

[matidau]

@mschering I've tested this and it does work, but so does the existing code :)

your find.php is more in the style of Z-Push, but there are a lot of references to Search instead of Find. Not sure if you want to put the work in to fix these up and merge the rest, but if you do, I would be happy to review it with the intent on merging.

[mschering]

I can only find references in the comment block on top?