Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When 'Return security-enabled groups only' is checked, no results are returned for Groups #109

Closed
NaveenKanukuntla opened this issue Nov 30, 2020 · 6 comments
Closed

When 'Return security-enabled groups only' is checked, no results are returned for Groups #109

NaveenKanukuntla opened this issue Nov 30, 2020 · 6 comments
Assignees
@Yvand
Labels
Issue

Comments

@NaveenKanukuntla
Copy link

When I check for 'Return security-enabled groups only'. No groups are returned. I have some Azure AD Groups and I do have groups that are synchronized from On-Prem Active Directory on my Dev Farm. I did not work either in V16 or V17 as well.

Here is my AzureCP Settings :
image

Here are my Claims Settings:
image

Here are my claim types:
http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name <-- Identifier Claim
http://schemas.microsoft.com/ws/2008/06/identity/claims/role
@Yvand
Copy link
Owner

Yvand commented Nov 30, 2020

Thank you for reporting this, I will test it soon and let you know if I repro

@Yvand Yvand self-assigned this Nov 30, 2020
@Yvand Yvand added the Issue label Nov 30, 2020
Yvand added a commit that referenced this issue Dec 1, 2020
@Yvand
Fix #109
5d1f26b
@Yvand Yvand added the bug label Dec 1, 2020
@Yvand
Copy link
Owner

Yvand commented Dec 1, 2020

It's absolutely a bug, fixed in 5d1f26b
Thank you for reporting it!

@stale
Copy link

stale bot commented Dec 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 31, 2020
@NaveenKanukuntla
Copy link
Author

NaveenKanukuntla commented Jan 6, 2021 •
edited
Loading

@Yvand : I have installed the latest release and the issue is now resolved. I can now search for users and also security groups.

@stale stale bot removed the stale label Jan 6, 2021
@Yvand
Copy link
Owner

Yvand commented Jan 7, 2021

Just to be clear, did you mean that it resolved the issue or not (you typed "not resolved")?

@NaveenKanukuntla
Copy link
Author

@Yvand : Sorry about my typo. The issue is now resolved.

@Yvand Yvand closed this as completed Jan 13, 2021
@Yvand Yvand mentioned this issue Feb 11, 2021
Merged
Yvand added a commit that referenced this issue Feb 16, 2021
@Yvand
Publish v19 (#116)
2f80c4d 
* Fix #109

* Update Microsoft.Graph and Microsoft.Identity.Client

* Add ConfigureAwait(false) to Task.WhenAll()

* Fix bug: set ExcludeMembers instead of ExcludeGuests in new AAD tenant dialog

* Better handle scenario when AzureCP cannot get an access token for a tenant

* Update CHANGELOG.md

* Update Microsoft.Identity.Client and Microsoft.Graph

* Update text in AzureCP global admin page

* Update CHANGELOG.md

* Update NuGet packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yvand Yvand

Labels
Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yvand @NaveenKanukuntla