Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No result in people picker if guest filter is enabled #107

Closed
staehelir opened this issue Nov 18, 2020 · 13 comments
Closed

No result in people picker if guest filter is enabled #107

staehelir opened this issue Nov 18, 2020 · 13 comments
Assignees
Labels

Comments

@staehelir
Copy link

We use SharePoint Foundation 2013 with the newest AzureCP version. We add a second Azure AD to the AzureCP and want to filter out guest accounts. When we enable guest filter, then the people picker can't find any account from the second Azure AD. After disable the guest account filter, then the people picker shows all account from the second Azure AD.

@Yvand
Copy link
Owner

Yvand commented Nov 18, 2020

Can you validate if the configuration of the AAD tenants is the one you expect using the script below:

Add-Type -AssemblyName "AzureCP, Version=1.0.0.0, Culture=neutral, PublicKeyToken=65dc6b5903b51636"
$config = [azurecp.AzureCPConfig]::GetConfiguration("AzureCPConfig")
$config.AzureTenants

Can you confirm if it is AzureCP 17?

@Yvand Yvand self-assigned this Nov 18, 2020
@Yvand Yvand added the Issue label Nov 18, 2020
@NaveenKanukuntla
Copy link

@Yvand : I do have the same issue. I do not seem to get any results if 'filter guest users' is selected when configuring my Azure Connection.

@Yvand
Copy link
Owner

Yvand commented Nov 30, 2020

Ok, I was waiting for @staehelir to send more data but it looks like an actual bug, I will repro it soon and let you know the result

@Yvand
Copy link
Owner

Yvand commented Dec 1, 2020

I tested with 2 tenants, 1 has ExcludeGuests set to true and the other to false:

Add-Type -AssemblyName "AzureCP, Version=1.0.0.0, Culture=neutral, PublicKeyToken=65dc6b5903b51636"
$config = [azurecp.AzureCPConfig]::GetConfiguration("AzureCPConfig")
$config.AzureTenants[0].ExcludeGuests=$true
$config.AzureTenants[1].ExcludeGuests=$false
$config.Update()

It all works as expected: guest accounts of AzureTenants[0] are filtered out and both members and guests are shown in AzureTenants[1].
@NaveenKanukuntla @staehelir am I missing something?

@NaveenKanukuntla
Copy link

@Yvand : I think I now understand what is going wrong.

When we add a Tenant, we have a choice to select 'Filter our Guest Users' on the configuration screen

image

So, when I configure like above and perform a search, the below is what I get.

image

image

But, when I configure the connection without selecting the 'Filter out Guest users on this tenant' and use PowerShell to update the filter attribute it works.

Identifier                  : xxxx
Name                        : xxxx
ApplicationId               : xxxx
ApplicationSecret           : xxxx
ExcludeMembers              : False
ExcludeGuests               : True
ClientCertificatePrivateKey : 
AuthenticationMode          : ClientSecret
GraphService                : 
UserFilter                  : 
GroupFilter                 : 
UserSelect                  : 
GroupSelect                 : 
UpgradedPersistedProperties : {}

So, if I do it through UI it does not work, but with PowerShell it does. Now, I do not know if the update made through PowerShell is really working, since I do not have any guest users in my tenant.

Interestingly, that does not reflect on the configuration page, even though it does show in my PowerShell result.
image
image

I will add some guest users and see. But for now, this is what I found out.

@Yvand
Copy link
Owner

Yvand commented Dec 3, 2020

@NaveenKanukuntla thank you for the details, it pointed me directly to the problem, it's really a dump issue: I set property ExcludeMembers instead of ExcludeGuests when the option was set in the new AAD tenant dialog...
It's fixed in 229c14d

@NaveenKanukuntla
Copy link

NaveenKanukuntla commented Dec 3, 2020

@Yvand : Great. Let me know when the latest version is out and I will test it for you.

@staehelir
Copy link
Author

@Yvand @NaveenKanukuntla thank you. It works over PowerShell!

@Yvand Yvand added the bug label Dec 4, 2020
@Yvand
Copy link
Owner

Yvand commented Dec 7, 2020

@NaveenKanukuntla I just published the pre-release, here is the link: https://github.com/Yvand/AzureCP/releases/tag/19.0.20201207.1262
Thanks!

@vargasfe
Copy link

vargasfe commented Dec 7, 2020 via email

@Yvand
Copy link
Owner

Yvand commented Dec 8, 2020

@vargasfe this bug is for the guest accounts filter, please open a separate issue for your scenario that is different.
Thanks

@Yvand
Copy link
Owner

Yvand commented Dec 14, 2020

@NaveenKanukuntla were you able to test the release?

@NaveenKanukuntla
Copy link

@Yvand : The issue is now resolved with the latest release. Thank you very much.

@Yvand Yvand closed this as completed Jan 7, 2021
@Yvand Yvand mentioned this issue Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants