Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDC] Increase WAL retention time when CDC stream is setup on table #2050

Closed
ndeodhar opened this issue Aug 13, 2019 · 1 comment
Closed

[CDC] Increase WAL retention time when CDC stream is setup on table #2050

ndeodhar opened this issue Aug 13, 2019 · 1 comment
Assignees
@hectorgcr
Labels
area/cdc Change Data Capture
Milestone
v2.0

Comments

@ndeodhar
Copy link
Contributor

Make the WAL retention time configurable via gflag. Use a default of 4 hours.
@ndeodhar ndeodhar added the area/cdc Change Data Capture label Aug 13, 2019
@ndeodhar ndeodhar added this to the v2.0 milestone Aug 13, 2019
@ndeodhar ndeodhar self-assigned this Aug 13, 2019
@bmatican bmatican assigned hectorgcr and unassigned ndeodhar Aug 21, 2019
@bmatican
Copy link
Contributor

Passing this to @hectorgcr since he should have most of the context of the retention since he set it up. Also, from discussing with @ndeodhar , we need this soon to ensure we can get a 2DC test going.

@hectorgcr hectorgcr mentioned this issue Aug 26, 2019
Open
hectorgcr added a commit that referenced this issue Aug 30, 2019
@hectorgcr
#2050: Increase WAL retention time when CDC stream is setup on table
1d2a9fb 
Summary: When a CDC stream is created, we modify the WAL retention time for all the table's tablets. This is done with an AlterTable request. The new time is controlled by the gflag cdc_wal_retention_time_secs, and it is the same for any table for which a CDC stream is created.

Test Plan: Verify that all the tests that create a CDC stream succeed

Reviewers: bogdan, rahuldesirazu, neha

Reviewed By: neha

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7115
d-uspenskiy pushed a commit to d-uspenskiy/yugabyte-db that referenced this issue Sep 5, 2019
@hectorgcr @d-uspenskiy
yugabyte#2050: Increase WAL retention time when CDC stream is setup o…
c262d45 
…n table

Summary: When a CDC stream is created, we modify the WAL retention time for all the table's tablets. This is done with an AlterTable request. The new time is controlled by the gflag cdc_wal_retention_time_secs, and it is the same for any table for which a CDC stream is created.

Test Plan: Verify that all the tests that create a CDC stream succeed

Reviewers: bogdan, rahuldesirazu, neha

Reviewed By: neha

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7115
@hectorgcr hectorgcr mentioned this issue Sep 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorgcr hectorgcr

Labels
area/cdc Change Data Capture
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@bmatican @ndeodhar @hectorgcr