Don't use a special case for message formatting based on policyID #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Conftest has identified issues with your resources The following warnings were identified. These are issues that indicate the resources are not following best practices.
|
|
Conftest has identified issues with your resources The following warnings were identified. These are issues that indicate the resources are not following best practices.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of handling this case in the action, the
format()function should include the policy ID if one is specified, this way the policy ID is shown to the user regardless of where they are running the policy. EG: https://github.com/plexsystems/konstraint/blob/f2e60d22ee5d589ea5e663aa49357e8505c68d81/examples/lib/core.rego#L22-L27