feat(log4j):add rollbar support #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liebstein
force-pushed
the
add-rollbar-to-metorikku
branch
from
d8ccbf5
to
64582e5
Compare
liebstein
changed the title
liebstein
force-pushed
the
add-rollbar-to-metorikku
branch
2 times, most recently
from
e926142
to
9d764e0
Compare
liebstein
force-pushed
the
add-rollbar-to-metorikku
branch
from
9d764e0
to
19db0a3
Compare
lyogev
reviewed
Aug 13, 2020
| log4j.appender.ROLLBAR=com.nextdoor.rollbar.RollbarLog4jAppender | ||
| log4j.appender.ROLLBAR.AccessToken=${ROLLBAR_ACCESS_TOKEN} | ||
| log4j.appender.ROLLBAR.Environment=${ROLLBAR_ENV:-production} | ||
| log4j.appender.ROLLBAR.layout=org.apache.log4j.PatternLayout |
There was a problem hiding this comment.
Maybe let's start with error?
| @@ -16,7 +16,7 @@ | |||
| # | |||
|
|
|||
| # Set everything to be logged to the console | |||
| log4j.rootLogger=INFO,console | |||
| log4j.rootLogger=INFO,console,ROLLBAR | |||
There was a problem hiding this comment.
Does this work if rollbar is not in this file?
| @@ -69,7 +69,8 @@ libraryDependencies ++= Seq( | |||
| "org.apache.avro" % "avro" % "1.8.2" % "provided", | |||
| "org.apache.hive" % "hive-jdbc" % "2.3.3" % "provided" excludeAll(excludeNetty, excludeNettyAll, excludeLog4j, excludeParquet), | |||
| "org.apache.hadoop" % "hadoop-aws" % "2.7.3" % "provided", | |||
| "com.amazon.deequ" % "deequ" % "1.0.4" excludeAll(excludeSpark) | |||
| "com.amazon.deequ" % "deequ" % "1.0.4" excludeAll(excludeSpark), | |||
| "com.nextdoor.rollbar" % "rollbar-log4j" % "1.0.2" | |||
There was a problem hiding this comment.
I think in order to use this feature
https://docs.rollbar.com/docs/java#synchronous-option
We need to create a custom appender, copy paste from here (https://github.com/zendesk/rollbar-log4j/blob/master/src/main/java/com/zendesk/rollbar/RollbarLog4jAppender.java)
There was a problem hiding this comment.
Or try fixing with a shutdown hook?
There was a problem hiding this comment.
I think the problem is they haven't implemented the close function there...
lyogev
reviewed
Sep 3, 2020
| log4j.appender.ROLLBAR.AccessToken=${ROLLBAR_ACCESS_TOKEN} | ||
| log4j.appender.ROLLBAR.Environment=${ROLLBAR_ENV:-production} | ||
| log4j.appender.ROLLBAR.layout=org.apache.log4j.PatternLayout | ||
| log4j.appender.ROLLBAR.Threshold=${ROLLBAR_ENV:-WARN} |
There was a problem hiding this comment.
ROLLBAR_ENV? Warn should be error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.