Generalization of Cas9LineageTracingDataSimulator #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colganwi
requested review from
Lioscro and
mattjones315
and removed request for
Lioscro
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 79.43% 79.49% +0.06%
==========================================
Files 89 89
Lines 7895 7916 +21
==========================================
+ Hits 6271 6293 +22
+ Misses 1624 1623 -1
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
mattjones315
requested changes
Aug 30, 2023
mattjones315
requested changes
Sep 7, 2023
mattjones315
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
Cas9LineageTracingDataSimulatormore general by addingself.mutation_priors_per_characterwhich allows for different characters to have different mutation distributions. The API is the same, exceptmutation_priorscan now be a list of lengthsize_of_cassetteornumber_of_cassettes * size_of_cassette. For consistency,mutation_ratenow also excepts lists ofsize_of_cassetteornumber_of_cassettes * size_of_cassetteinstead of justnumber_of_cassettes * size_of_cassette.