Add a C API #39
Open
Add a C API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #38. |
jdm
force-pushed
the
capi
branch
3 times, most recently
from
a203fa0
to
15e277b
Compare
|
Hmm, I should have designed this API by looking at examples/main.rs instead of Yoric/servo@70f90d0 :< |
…anges made to C API.
… through function arguments as required.
jdm
force-pushed
the
capi
branch
2 times, most recently
from
2d2ac76
to
f7b61fb
Compare
jdm
force-pushed
the
capi
branch
6 times, most recently
from
77e9710
to
f3c72d7
Compare
|
Thanks a lot for the PR. I'll try and review it by tomorrow. |
| libc = "0" | ||
|
|
||
| [dependencies.telemetry] | ||
| path = "../" |
|
I'm not pulling yet as I'm discussing with the Telemetry team about changes in the histograms that would probably require several API changes. |
|
Yep, that makes sense. I also started to address your comments as well as support less trivial types of histograms and got stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to use the library from any language with a C-compatible FFI.