Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move margin bottom of the form section to the close editor snippet button #615

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

igorschoester
Copy link
Member

Summary

This PR can be summarized in the following changelog entry:

  • Moves the margin bottom from the FormSections to the CloseSnippetEditor button.

Relevant technical choices:

  • N/A

Test instructions

This PR can be tested by following these steps:

  • Ensure the snippet editor margins / paddings look the same on the metabox.
  • On the settings pages this will solve a to-much-margin-at-the-bottom error from @jcomack

@boblinthorst
Copy link
Contributor

CR: ok 👍

@boblinthorst
Copy link
Contributor

Acceptance: ok 👍. Looks good on a post

@boblinthorst boblinthorst merged commit eb808ba into develop Jun 21, 2018
@boblinthorst boblinthorst deleted the adapt-snippet-editor-margin branch June 21, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants