Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the snippet editor placeholder color contrast #603

Merged

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jun 18, 2018

Summary

This PR can be summarized in the following changelog entry:

  • Improve the snippet editor placeholder color contrast

Relevant technical choices:

  • Uses the same gray color we use on MyYoast

Test instructions

  • currently, the placeholder text in the description field has a light gray color that becomes even lighter when the field is focused:

screen shot 2018-06-18 at 10 31 55

screen shot 2018-06-18 at 10 32 03

This PR changes the color to #646464 in both states (normal and focused).

  • test the standalone version: yarn-start and go to localhost:3333
  • open the snippet editor
  • empty the description field to make the placeholder text appear
  • check the placeholder color is always #646464 also when the field is focused
  • optionally, yarn-link to the plugin release-7.7 branch and test also in the plugin

Fixes #602
Fixes Yoast/wordpress-seo#9874

@afercia
Copy link
Contributor Author

afercia commented Jun 18, 2018

Connects to Yoast/wordpress-seo#9874

@afercia
Copy link
Contributor Author

afercia commented Jun 18, 2018

Trying to wake up Waffle:

Fixes Yoast/wordpress-seo#9874

@boblinthorst
Copy link
Contributor

CR: ok 👍

@boblinthorst
Copy link
Contributor

Acceptance: ok 👍

@boblinthorst boblinthorst added this to the Snippet Preview milestone Jun 19, 2018
@boblinthorst boblinthorst merged commit 1079b4f into develop Jun 19, 2018
@boblinthorst boblinthorst deleted the stories/af/602-snippet-editor-placeholder-color-contrast branch June 19, 2018 09:17
@abotteram abotteram modified the milestones: Snippet Preview, 4.3 Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants