Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded webpack to 4.7 #501

Merged
merged 2 commits into from
May 7, 2018
Merged

Upgraded webpack to 4.7 #501

merged 2 commits into from
May 7, 2018

Conversation

abotteram
Copy link
Contributor

Summary

I upgraded the development app to use webpack 4, since this needed to happen some time in the future anyway and I got an error when I used yarn install because of an incompatible package with node 9.

This PR can be summarized in the following changelog entry:

  • Upgrades webpack to version 4+

Relevant technical choices:

  • Removed JSON-loader
  • Set webpack mode to development

Test instructions

This PR can be tested by following these steps:

  • Install dependencies
  • Make sure the development app works as expected

Fixes #

@atimmer
Copy link
Contributor

atimmer commented May 7, 2018

CR & Acceptance done 👍🏻

@atimmer atimmer merged commit cb1bf09 into develop May 7, 2018
@atimmer atimmer deleted the stories/upgrade-webpack-4 branch May 7, 2018 10:53
@abotteram abotteram added this to the 3.6 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants