Optional ScreenReaderText after the Collapsible title #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {string} props.suffixIconColor CSS color of the suffix icon. | ||
| * @param {string} props.suffixIconCollapsed Suffix icon when in collapsed state. | ||
| * @param {string} props.title Title for in the Heading. | ||
| * @param {string} props.titleScreenReaderText Chance for an extra |
There was a problem hiding this comment.
I'm not sure what "Chance for an extra" means for this parameter. Could you clarify the description?
| * @param {string} props.suffixIconColor CSS color of the suffix icon. | ||
| * @param {string} props.suffixIconCollapsed Suffix icon when in collapsed state. | ||
| * @param {string} props.title Title for in the Heading. | ||
| * @param {string} props.titleScreenReaderText Chance for an extra |
boblinthorst
deleted the
stories/450-add-screenreader-text-for-collapsible-header-icons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
aria-labelon the SvgIcon. Props to @aferciaTest instructions
This PR can be tested by following these steps:
yarn install && yarn start.localhost:3333and then click on the right most buttonSidebar Collapsible.⌘ + F5on a mac) and the top one should have an extra text.Fixes #450