Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a toggle component #626

Closed
IreneStr opened this issue Jun 28, 2018 · 2 comments
Closed

Create a toggle component #626

IreneStr opened this issue Jun 28, 2018 · 2 comments

Comments

@IreneStr
Copy link
Contributor

IreneStr commented Jun 28, 2018

schermafbeelding 2018-06-28 om 08 57 47

This toggle component will be used to mark cornerstone content in the sidebar, but probably also in other places later. Therefore, make it flexible. Use backported Gutenberg components when possible.

Context of the toggle:

sidebar 7 expanded

@afercia
Copy link
Contributor

afercia commented Jun 28, 2018

There's a (slightly) long debate about these switch toggles going on in Gutenberg, see WordPress/gutenberg#2146

Regardless of what will happen there, if we really want to use these kind of UI I'd strongly recommend to implement it in a way that there's always a clear textual indication of the switch state.

Worth reminding the MyYoast toggles do use a visible hint "On/Off" to give some visual feedback about the switch state:

screen shot 2018-06-28 at 13 14 34

There are also different options to give the same visual feedback:

  • material.io suggests to use the visible inline label (if any):

m io switches

  • Gutenberg provides a description below the inline label that could be used for this purpose:

gdescription

@IreneStr IreneStr removed the queue ★ label Jul 4, 2018
@omarreiss
Copy link
Contributor

So we decided to go with MyYoast toggles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants