Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activeKeyword-based logic to openSidebarSections-based logic #9377

Conversation

maartenleenders
Copy link
Contributor

@maartenleenders maartenleenders commented Mar 28, 2018

Summary

This PR can be summarized in the following changelog entry:

  • Makes sure you can open multiple keyword sections at the same time.

Relevant technical choices:

  • Previously activeKeyword kept track of the keyword tab that was opened. We now opted for an array that keeps track of all open sections, which can be multiple.

Test instructions

This PR can be tested by following these steps:

  • Checkout branch and run yarn install and yarn test (when the tests have passed CR you can assume they are fine, though do check them).
  • You could expose the store and action to the window in edit.js, and dispatch (store.dispatch( action() ) and see whether the state was changed correctly.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

@maartenleenders
Copy link
Contributor Author

Closing in favor of #9381

@maartenleenders maartenleenders deleted the stories/9305-change-activeKeyword-to-activeSections branch March 29, 2018 11:29
@IreneStr IreneStr added this to the Content Analysis in Sidebar milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants