21628 refactor isprivateblog preference

[vraja-pro]

Context

• Refactor isPrivatBlog preference.

Summary

This PR can be summarized in the following changelog entry:

• Refactors isPrivateBlog preference.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

• Go to Settings->Reading and tick the checkbox for Search engine visibility
• Edit a post and go to Advanced tab
• Check you see the following warnings:
  
• Go to Settings->Reading and uncheck the checkbox for Search engine visibility
• Edit a post and go to Advanced tab
• Check you don't see the warning anymore.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #21628

[coveralls]

Pull Request Test Coverage Report for Build 061e5a472ed9eb41c049f7d11c82e96fdc53221b

Details

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+5.2%) to 54.719%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/editors/framework/site/base-site-information.php	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
inc/class-wpseo-utils.php	1	43.27%

Totals
Change from base Build bc3a4e966336e035c87bf7445627c054d34ed794:	5.2%
Covered Lines:	29762
Relevant Lines:	54635

---

💛 - Coveralls

[leonidasmi]

CR: LGTM except a minor thing about changing the check of isPrivateBlog beloe

[leonidasmi]

CR + Acceptance Test is ✅