Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency injection: fix Loader_Pass being broken on Windows #20503

Merged
merged 2 commits into from
Jul 17, 2023

Commits on Jul 13, 2023

  1. Dependency injection: fix Loader_Pass being broken on Windows

    Follow up on 20074, which changed the `Loader_Pass` class to compare paths against (other) paths with hard-coded forward slashes.
    
    This silently broke the Dependency injection layer for anyone compiling on Windows, i.e. the DI container scripts would run without errors, but once the DI container is attempted to be used, everything breaks.
    
    This commit should fix that in a similar way as a previous similar issue was fixed in another part of the DI container setup (PR 16364).
    jrfnl committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a870890 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Configuration menu
    Copy the full SHA
    7030a3e View commit details
    Browse the repository at this point in the history