Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Di improvements #20074

Merged
merged 21 commits into from
Jun 20, 2023
Merged

Di improvements #20074

merged 21 commits into from
Jun 20, 2023

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented Mar 29, 2023

Context

  • We want to add a searchAction piece to the schema graph upon a successfully performed search action

Summary

This PR can be summarized in the following changelog entry:

  • Updates the dependency container to allow for non public classes.

Relevant technical choices:

  • The DI container has been updated to allow for objects that should not be autwired
  • A completely new directory structure has been implemented following the DDD paradigm
  • In the DI container all the classes are now registered as non-public and made public later, to ensure backward compatibility

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Perform a search in the frontend of your site
  • View the source code of the page and verify in the schema you have the searchAction schema piece, e.g.:
{
	            "@type": "SearchAction",
	            "actionStatus": "https://schema.org/CompletedActionStatus",
	            "query": "hello",
	            "result": {
	                "@id": "https://basic.wordpress.test/?s=hello"
	            }
	        }

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unit tests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

Fixes #19803

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 29, 2023
@thijsoo thijsoo changed the title Set all base definitions to false Di improvments Mar 29, 2023
@thijsoo thijsoo changed the title Di improvments Di improvements Mar 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5321980160

  • 19 of 19 (100.0%) changed or added relevant lines in 5 files are covered.
  • 593 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 40.136%

Files with Coverage Reduction New Missed Lines %
src/generated/container.php 593 0%
Totals Coverage Status
Change from base Build 5321957591: 0.04%
Covered Lines: 9664
Relevant Lines: 24078

💛 - Coveralls

@thijsoo thijsoo added this to the 20.11 milestone Jun 20, 2023
@thijsoo thijsoo merged commit 4e9f987 into trunk Jun 20, 2023
53 checks passed
@thijsoo thijsoo deleted the feature/di-improvements branch June 20, 2023 12:49
@thijsoo thijsoo added changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish DI container changes
4 participants